-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use postgresql for tests #450
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
7298668 | Triggered | Generic High Entropy Secret | 73698d9 | .env.test | View secret |
7298668 | Triggered | Generic High Entropy Secret | 6dbd020 | .env.test | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
==========================================
- Coverage 82.70% 82.67% -0.04%
==========================================
Files 98 98
Lines 6142 6142
==========================================
- Hits 5080 5078 -2
- Misses 1062 1064 +2 ☔ View full report in Codecov by Sentry. |
c9d7cb2
to
a363335
Compare
to prevent object from a test file from interfere with an other one
a363335
to
6861a16
Compare
### Description Fix #403 Add Postgresql databse support for tests. Use a TestAppClient per test file, to prevent tests from a module to impact other modules Configure a Postgresql database for the test workflow. Run tests with Postgresql. Run migration tests with SQLite and Postgresql. ### Checklist - [x] Created tests which fail without the change (if possible) - [x] All tests passing - [x] Extended the documentation, if necessary --------- Co-authored-by: julien4215 <120588494+julien4215@users.noreply.github.com>
### Description If we don't drop the test database before migration tests, missing columns won't be detected This was broken since #450
Description
Fix #403
Add Postgresql databse support for tests. Use a TestAppClient per test file, to prevent tests from a module to impact other modules
Configure a Postgresql database for the test workflow.
Run tests with Postgresql. Run migration tests with SQLite and Postgresql.
Checklist