Skip to content

Remove JWT FPs on images in GitHub private issues #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 1, 2024
Merged

Remove JWT FPs on images in GitHub private issues #88

merged 3 commits into from
Feb 1, 2024

Conversation

aegilops
Copy link
Collaborator

Removes alerts of JWTs in private GitHub issues in the image URLs, by ignoring a specific prefix now used in the JWTs

@aegilops aegilops requested a review from GeekMasher as a code owner January 15, 2024 15:44
@advanced-security-actions-auth
Copy link

advanced-security-actions-auth bot commented Jan 15, 2024 •
edited
Loading

✅ Markdown Validation Passed 🚀!

GeekMasher
GeekMasher approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@GeekMasher GeekMasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@aegilops aegilops merged commit dc8fdbd into main Feb 1, 2024
@aegilops aegilops deleted the jwt-image-fp branch February 1, 2024 14:05
@aegilops aegilops mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@GeekMasher GeekMasher GeekMasher approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aegilops @GeekMasher