Skip to content

Ignore "excluded_repos.csv" for code scanning alerts of GitHub Enterprise Cloud #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

parroty
Copy link
Contributor

@parroty parroty commented Dec 13, 2022

Background

Hi 👋 . I just realized that enterprise-level code-scanning-alerts function generates excluded_repos.csv in an unexpected format (not CSV).

$ ls
cs_list.csv         dependabot_list.csv excluded_repos.csv  secrets_list.csv

$ head -c 100 excluded_repos.csv
"{'number': 1, 'created_at': '2022-12-13T14:34:38Z', 'updated_at': '2022-12-13T14:34:39Z', 'url': 'h

I am wondering that the excluded_repos.csv part is intended for GitHub Enterprise Server which requires multiple API calls per repository. But, it would not apply for GitHub Enterprise Cloud which can get the entire list with a single API call.

Changes

  • Remove excluded_repos.csv logic for write_enterprise_cloud_cs_list function.

@some-natalie some-natalie merged commit 3dc93f1 into advanced-security:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants