Skip to content

Honour --no-precompile setting when bundling query packs #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Honour --no-precompile setting when bundling query packs #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions codeql_bundle/helpers/bundle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,8 @@ def bundle_query_pack(pack: ResolvedCodeQLPack):
)
# Recompile the query pack with the assumption that all its dependencies are now in the bundle.
self.codeql.pack_create(
pack_copy, self.bundle_path / "qlpacks", self.bundle_path
pack_copy, self.bundle_path / "qlpacks", self.bundle_path,
disable_precompilation=self.disable_precompilation
)
else:
logging.info(f"Bundling the query pack {pack.config.name}.")
Expand All @@ -632,7 +633,8 @@ def bundle_query_pack(pack: ResolvedCodeQLPack):
with pack_copy.path.open("w") as fd:
yaml.dump(qlpack_spec, fd)

self.codeql.pack_create(pack_copy, self.bundle_path / "qlpacks")
self.codeql.pack_create(pack_copy, self.bundle_path / "qlpacks",
disable_precompilation=self.disable_precompilation)

sorted_packs = list(pack_sorter.static_order())
logger.debug(
Expand Down