Skip to content

[W-12688568] Missing protocol on baseUrl #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 2, 2023
Merged

[W-12688568] Missing protocol on baseUrl #34

merged 3 commits into from
Jun 2, 2023

Conversation

carowright
Copy link
Contributor

Bug: Missing protocol on baseUrl.
Fix: Ensure url on every change.

@carowright carowright requested a review from alexpmule June 2, 2023 17:51
alexpmule
alexpmule approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@alexpmule alexpmule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carowright carowright merged commit 65f61de into main Jun 2, 2023
@carowright carowright deleted the fix/W-12688568/missing-protocol branch June 2, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpmule alexpmule alexpmule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carowright @alexpmule