Skip to content

Persist custom query parameters when updating URL data #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 16, 2022
Merged

Persist custom query parameters when updating URL data #30

merged 6 commits into from
Nov 16, 2022

Conversation

twoplustwoone
Copy link
Contributor

@twoplustwoone twoplustwoone commented Nov 16, 2022 •
edited
Loading

Updating the serverValue or serverType of the request panel causes the _queryModel to reset custom values. When re computing the URL data, check for custom values, and if they are present, add them to the _queryModel property.

@twoplustwoone twoplustwoone merged commit 5d68df6 into main Nov 16, 2022
@twoplustwoone twoplustwoone deleted the fix/query-params-lost-after-server-change branch November 16, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carowright carowright carowright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twoplustwoone @carowright