Fix border bottom style

[benri]

• Fixes border property overriding the style of border-bottom when the CSS variable is undefined
  ( Customize method style #38 (comment) )

• Fixes margin property overriding default margin-top and margin-bottom style on .url-area
  ( 3d6a35a#r51355569 )

[deiteris]

@jarrodek, @twoplustwoone, any ETA when this is going to be reviewed and merged?

[twoplustwoone]

This is more restrictive than what we have now. I would at least keep the border attribute, and use this current border-bottom value as the default border-bottom value for the border attribute

[deiteris]

@twoplustwoone but this is not how it works. border controls the border of all sides at once. I've already mentioned that and a possible solution in my more detailed explanation here:
advanced-rest-client/api-body-document#26 (comment)

[twoplustwoone]

Yes I understand, but why not do something like this instead:

border: var(--api-parameters-document-title-border);
border-bottom: var(--api-parameters-document-title-border-bottom, 1px var(--api-parameters-document-title-border-color, #e5e5e5) solid);

This would cover being able to change theborder-bottom and override border, which would fit what you mentioned in that PR, correct?

[deiteris]

This would cover being able to change the border-bottom and override border, which would fit what you mentioned in that PR, correct?

Not exactly. Your solution will be backward compatible, so I have no objections here. However, it has two inconveniences (depending on the use cases you actually have or plan):

1. Let's say I want my expandable menu to be bordered from all sides (even though I hardly image such a use case). I have --api-parameters-document-title-border to do that, but I also must set --api-parameters-document-title-border-color to avoid border-bottom overriding my bottom border with the default value.
   And here's what this will look like:
   

2. This will not work for the use case, where one would like to have both bottom and top borders.
   Here's what this could look like:
   

But all this is just an idea based on the wrong idea 😄. As @benri already said in that PR, the reason he did this, is to hide the bottom border (which could be done just by using the transparent color).

If it doesn't make much sense to you - keep your solution, my only wish is to keep it at least backward compatible 🙂

[deiteris]

@twoplustwoone, @benri, any news regarding this change? And what about this one advanced-rest-client/api-body-document#26?