Add TEI XML parser for Grobid output files #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you look into why the tests fail? Otherwise it can be merged. |
|
I have no idea why the tests fail, but they are also failing in the current release (see travis report). I'm pretty sure the things I modified do pass all tests in tests/test_unit/test.py. Maybe you have made some mods but not pushed them to github? |
|
Oh yeah, I didn't see the main build is failing. I'll take a look. |
|
I take that back. It was passing on the last build. Maybe some dependencies got updated recently that is causing issues. |
|
Go ahead and merge. It's something with the functional tests, and most likely they updated rabbit on travis or something. |
aaccomazzi
added a commit
that referenced
this pull request
Oct 8, 2015
Add TEI XML parser for Grobid output files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up other minor issues.