Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/v1/customers doesn't accept email filter query param #153

Open
lowlyocean opened this issue Sep 25, 2020 · 0 comments
Open

/v1/customers doesn't accept email filter query param #153

lowlyocean opened this issue Sep 25, 2020 · 0 comments

Comments

@lowlyocean
Copy link
Contributor

this line raises an exception if receiving a GET request to /v1/customers containing email parameter e.g.
stripe.Customer.list(email = 'address@domain.com')
@lowlyocean lowlyocean mentioned this issue Sep 25, 2020
Closed
willbarre2 added a commit to willbarre2/localstripe that referenced this issue Jun 21, 2022
@willbarre2
feat(customers): Find customers by email
df9b5f4 
As described here
https://stripe.com/docs/api/customers/list#list_customers-email,
the Stripe API allows you to find one or more customers by their
email addresses by adding the query param `?email=<something>`
to the `/v1/customers` route.

Stripe doesn't care about the format of the emails we send in
the request, as long as they are strings.
If we request with an unknown address, it returns an empty list.
On the other hand, if we request with a known address, it returns
a list of customers who have this address in their email field.
So there can be several customers with the same email address.

Let's emulate this behavior.

Closes:
  adrienverge#154
  adrienverge#153
@willbarre2 willbarre2 mentioned this issue Jun 21, 2022
Merged
willbarre2 added a commit to willbarre2/localstripe that referenced this issue Jun 22, 2022
@willbarre2
feat(customers): Find customers by email
72c95b7 
As described here
https://stripe.com/docs/api/customers/list#list_customers-email,
the Stripe API allows you to find one or more customers by their
email addresses by adding the query param `?email=<something>`
to the `/v1/customers` route.

Stripe doesn't care about the format of the emails we send in
the request, as long as they are strings.
If we request with an unknown address, it returns an empty list.
On the other hand, if we request with a known address, it returns
a list of customers who have this address in their email field.
So there can be several customers with the same email address.

Let's emulate this behavior.

Closes:
  adrienverge#154
  adrienverge#153
willbarre2 added a commit to willbarre2/localstripe that referenced this issue Jun 23, 2022
@willbarre2
feat(customers): Find customers by email
de053e0 
As described here
https://stripe.com/docs/api/customers/list#list_customers-email,
the Stripe API allows you to find one or more customers by their
email addresses by adding the query param `?email=<something>`
to the `/v1/customers` route.

Stripe doesn't care about the format of the emails we send in
the request, as long as they are strings.
If we request with an unknown address, it returns an empty list.
On the other hand, if we request with a known address, it returns
a list of customers who have this address in their email field.
So there can be several customers with the same email address.

Let's emulate this behavior.

Closes:
  adrienverge#154
  adrienverge#153
bravier pushed a commit that referenced this issue Jun 27, 2022
@willbarre2 @bravier
feat(customers): Find customers by email
dfc3219 
As described here
https://stripe.com/docs/api/customers/list#list_customers-email,
the Stripe API allows you to find one or more customers by their
email addresses by adding the query param `?email=<something>`
to the `/v1/customers` route.

Stripe doesn't care about the format of the emails we send in
the request, as long as they are strings.
If we request with an unknown address, it returns an empty list.
On the other hand, if we request with a known address, it returns
a list of customers who have this address in their email field.
So there can be several customers with the same email address.

Let's emulate this behavior.

Closes:
  #154
  #153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow email query param in /v1/customers lowlyocean/localstripe
1 participant
@lowlyocean