Prevent refunds on a failed charge

adrienverge · Oct 31, 2024 · 6b0ff20 · 6b0ff20
1 parent caa0e94
commit 6b0ff20
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/localstripe/resources.py b/localstripe/resources.py
@@ -2607,6 +2607,8 @@ def __init__(self, charge=None, payment_intent=None, amount=None,
             charge = payment_intent_obj.latest_charge.id
 
         charge_obj = Charge._api_retrieve(charge)
+        if charge_obj.status == 'failed':
+            raise UserError(400, 'Cannot refund a failed payment.')
 
         # All exceptions must be raised before this point.
         super().__init__()

diff --git a/test.sh b/test.sh
@@ -856,6 +856,14 @@ status=$(
   | grep -oE '"status": "failed"')
 [ -n "$status" ]
 
+# cannot refund a failed charge
+code=$(
+  curl -sg -o /dev/null -w "%{http_code}" \
+       -u $SK: $HOST/v1/refunds \
+       -d charge=$charge \
+       -X POST)
+[ "$code" = 400 ]
+
 # create a pre-auth charge, observe 402 response
 code=$(
   curl -sg -o /dev/null -w "%{http_code}" \