Skip to content

Commit

Permalink
Avoid recording additional light attributes (home-assistant#121776)
Browse files Browse the repository at this point in the history
  • Loading branch information
bdraco authored and adriencog committed Jul 13, 2024
1 parent 08f1cec commit 9bbe12f
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 1 deletion.
10 changes: 10 additions & 0 deletions homeassistant/components/light/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -864,6 +864,16 @@ class LightEntity(ToggleEntity, cached_properties=CACHED_PROPERTIES_WITH_ATTR_):
ATTR_MAX_MIREDS,
ATTR_MIN_COLOR_TEMP_KELVIN,
ATTR_MAX_COLOR_TEMP_KELVIN,
ATTR_BRIGHTNESS,
ATTR_COLOR_MODE,
ATTR_COLOR_TEMP,
ATTR_COLOR_TEMP_KELVIN,
ATTR_EFFECT,
ATTR_HS_COLOR,
ATTR_RGB_COLOR,
ATTR_RGBW_COLOR,
ATTR_RGBWW_COLOR,
ATTR_XY_COLOR,
}
)

Expand Down
23 changes: 22 additions & 1 deletion tests/components/light/test_recorder.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,23 @@

from homeassistant.components import light
from homeassistant.components.light import (
ATTR_BRIGHTNESS,
ATTR_COLOR_MODE,
ATTR_COLOR_TEMP,
ATTR_COLOR_TEMP_KELVIN,
ATTR_EFFECT,
ATTR_EFFECT_LIST,
ATTR_HS_COLOR,
ATTR_MAX_COLOR_TEMP_KELVIN,
ATTR_MAX_MIREDS,
ATTR_MIN_COLOR_TEMP_KELVIN,
ATTR_MIN_MIREDS,
ATTR_RGB_COLOR,
ATTR_RGBW_COLOR,
ATTR_RGBWW_COLOR,
ATTR_SUPPORTED_COLOR_MODES,
ATTR_XY_COLOR,
DOMAIN,
)
from homeassistant.components.recorder import Recorder
from homeassistant.components.recorder.history import get_significant_states
Expand Down Expand Up @@ -50,7 +61,7 @@ async def test_exclude_attributes(recorder_mock: Recorder, hass: HomeAssistant)
await async_wait_recording_done(hass)

states = await hass.async_add_executor_job(
get_significant_states, hass, now, None, hass.states.async_entity_ids()
get_significant_states, hass, now, None, hass.states.async_entity_ids(DOMAIN)
)
assert len(states) >= 1
for entity_states in states.values():
Expand All @@ -62,3 +73,13 @@ async def test_exclude_attributes(recorder_mock: Recorder, hass: HomeAssistant)
assert ATTR_FRIENDLY_NAME in state.attributes
assert ATTR_MAX_COLOR_TEMP_KELVIN not in state.attributes
assert ATTR_MIN_COLOR_TEMP_KELVIN not in state.attributes
assert ATTR_BRIGHTNESS not in state.attributes
assert ATTR_COLOR_MODE not in state.attributes
assert ATTR_COLOR_TEMP not in state.attributes
assert ATTR_COLOR_TEMP_KELVIN not in state.attributes
assert ATTR_EFFECT not in state.attributes
assert ATTR_HS_COLOR not in state.attributes
assert ATTR_RGB_COLOR not in state.attributes
assert ATTR_RGBW_COLOR not in state.attributes
assert ATTR_RGBWW_COLOR not in state.attributes
assert ATTR_XY_COLOR not in state.attributes

0 comments on commit 9bbe12f

Please sign in to comment.