Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes-issue-78 #80

Merged
merged 2 commits into from
Sep 13, 2023
Merged

fixes-issue-78 #80

merged 2 commits into from
Sep 13, 2023

Conversation

sarafurd
Copy link
Contributor

No description provided.

@adrianyorke
Copy link
Owner

adrianyorke commented Sep 13, 2023

Fixes #78

@adrianyorke
Copy link
Owner

A couple of small changes:

  1. Line 1 and 2 are repeated. ACTION: delete either line 1 or line 2
  2. The document naming is quite specific, it must be CONTRIBUTING.md otherwise github with keep nagging me about creating contributing guidelines. You can simply rename the file then git add/commit/push to the same branch and I will see your new commit here in the same PR.

Interestingly, one of the automated tests failed. I will investigate further but I don't think it's anything you have done.

@adrianyorke
Copy link
Owner

Re-running the failed check was successful. It timed out for some reason. I will run all the checks again when you have submitted the final changes then merge your branch.

@adrianyorke
Copy link
Owner

@all-contributors please add @sarafurd for documentation & maintenance

@allcontributors
Copy link
Contributor

@adrianyorke

I've put up a pull request to add @sarafurd! 🎉

@adrianyorke adrianyorke merged commit c335d09 into adrianyorke:master Sep 13, 2023
6 of 7 checks passed
@adrianyorke
Copy link
Owner

Merged, thank you so much @sarafurd - great job!

I will add you to the Project Contributors section of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants