Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 64bits coordinate #55

Merged
merged 3 commits into from
Aug 23, 2019

Conversation

roznet
Copy link
Contributor

@roznet roznet commented Aug 18, 2019

Hi,

  1. I made the follow two changes to the code: one so that I can use the code from data already loaded in memory (in my case the data of the fit file comes from a database, not a file)
  2. fixed a bug by which the gps coordinate on a 64bit system didn't apply the correction for the sign properly and thus were in correct when the location had a <0 longitude.
    Hope it's ok and helps

@adriangibbons
Copy link
Owner

Thanks @roznet once I've managed to get the Travis CI checks to run successfully I will merge!

It seems that PHP version 5.5 as it's quite old and no longer supported by default.

@adriangibbons adriangibbons merged commit 1acf349 into adriangibbons:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants