Added ability to flush Zipkin spans to Kafka Exporter #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice this looks like a nice interim step towards flowing to kafka during the simulation #67 |
|
yes, I didn't want to implement live flowing yet as it would mean more refactoring and adjusting of the current code base. More than happy to build it but would like some comments from @adrianco on expected direction first. I was thinking making the flow package an interface so we could have different output stream implementations. |
|
Thanks! I'll take a look over the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If running an actual Kafka backed Zipkin installation this update allows one to send the flow output to Kafka for direct injection into Zipkin using the Kafka collector.