Support colored output on screen && add new level: SUCCESS #2
Conversation
adoyle-h
left a comment
adoyle-h
left a comment
There was a problem hiding this comment.
Thanks for your commits. I have reviewed it and left some comments.
| if [[ "${ARRAY_LEVEL_COLOR[$level]+isset}" ]]; then | ||
| return 0 | ||
| else | ||
| return 1 |
There was a problem hiding this comment.
You should use "echo yes/no" instead of "return 0/1" to represent the exit status of function. Because the process will be terminated with non-zero exit code when current shell has set set -o errexit.
| _levelExists $level | ||
| local levelExists=$? | ||
|
|
||
| if [[ "$levelExists" == "0" ]]; then |
There was a problem hiding this comment.
_levelExists function is unnecessary.
I think if [[ "${ARRAY_LEVEL_COLOR[$level]:+isset}" ]]; then is simple enough.
| else | ||
| echo "$msg" | ||
| local levelColor=$(_getLevelColor $level) | ||
| echo -e "${levelColor}${msg}${BASH_COLOR_CODE_DEFAULT}" |
There was a problem hiding this comment.
msg may contain ANSI escape sequences.
Use printf '%b%s%b\n' "${levelColor}" "${msg}" "${BASH_COLOR_CODE_DEFAULT}".
| fi | ||
| } | ||
|
|
||
| function _getLevelColor(){ |
There was a problem hiding this comment.
Put this function definition before _echo.
There was a problem hiding this comment.
The function definition should be function name() {, not function name(){.
| date_time=$(_date_time) | ||
| function_name="${FUNCNAME[2]}" | ||
| _echo "[$date_time][$level]($function_name) $msg" | ||
| _echo $level "[$date_time][$level]($function_name) $msg" |
| local level=$1 | ||
|
|
||
| if [[ -n "$LOG_TARGET" ]] ;then | ||
| echo "$msg" | tee >> "$LOG_TARGET" |
There was a problem hiding this comment.
I think it should support colored output to screen, while no-colored output to file.
printf '%b%s%b\n' "${levelColor}" "${msg}" "${BASH_COLOR_CODE_DEFAULT}"
echo "$msg" >> "$LOG_TARGET"
| { | ||
| # bash -n check the syntax of logger.sh. | ||
| # If there is an error, it will stop the test script right now. | ||
| bash -n "$CUR_FILE_DIR"/../src/logger.sh "" |
There was a problem hiding this comment.
Because of set -o errexit at line 3, the process will be terminated immediately when this line return non-zero exit code, and it will not reach line 18.
|
|
||
|
|
||
| function loggerShCheck() | ||
| { |
There was a problem hiding this comment.
Use function loggerShCheck() {. Follow the coding style.
| *Note: It will print lines in color according the level (e.g. ERROR in red, WARN in orange and so on)* | ||
|
|
||
| Print message to `stdout` and write it to a file: `source logger.sh "<output-path>"`. | ||
| *Note: No color of line in this mode* |
There was a problem hiding this comment.
I think it should support colored output to screen, while no-colored output to file.
|
|
||
|
|
||
|
|
||
| function colorCheck() { |
There was a problem hiding this comment.
This function is unnecessary. The foo function will print colored texts.
|
|
adoyle-h
changed the title
2 participants
I've unnexpectedly found the time to develop the feature I proposed you (issue #1 ).
3 files where modified: