Using proper laud countdown before cleaning of repository #3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judovana
changed the title
sxa
reviewed
Apr 3, 2024
Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
I definitely do not insists on this, but come to me as a good idea since I already at least once overlooked that and lsot build. |
karianna
requested changes
Apr 4, 2024
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
while [ $i -gt 0 ] ; do echo -n " $i " && sleep 1 && i=$(($i-1)) ; done && echo " $i"
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2004 (style): $/${} is unnecessary on arithmetic variables.
karianna
approved these changes
Apr 4, 2024
andrew-m-leonard
approved these changes
Apr 4, 2024
|
ok. two approvers done. What now? Can anybody merge please? |
|
ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is couple of
here in log only the
doing osmething terrible in Xsappear.I think it may be better to print out proper dynamic countdown instead of just dark screen. WDYT?
I had put it to commn.sh, but some other place may be better. Also I had used it as example only on two places in prepareWorkspace, where there definitely is more applicable places over scripts.
WDYT?