Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily patch architecture confusion when cross-compiling on mac #3619

Merged
merged 12 commits into from
Jan 30, 2024
Merged

Temporarily patch architecture confusion when cross-compiling on mac #3619

merged 12 commits into from
Jan 30, 2024

Commits on Jan 26, 2024

  1. Temporarily patch architecture confusion when cross-compiling on mac 

    Currently, when we build an x64 mac build on an arm64 machine, we put
arm64 all over the place by mistake.

This change is to partially compensate for that mistake until such
time as we can impliment a comprehensive seperation of build
architecture and target architecture in our build scripts.

Signed-off-by: Adam Farley <adfarley@redhat.com>
    @adamfarley
    adamfarley committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    09e62f7 View commit details
    Browse the repository at this point in the history

  2. Tidying the fix for simplicity 

    Signed-off-by: Adam Farley <adfarley@redhat.com>
    @adamfarley
    adamfarley committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    2cc403c View commit details
    Browse the repository at this point in the history

  3. Fixing typo in if statement 

    Signed-off-by: Adam Farley <adfarley@redhat.com>
    @adamfarley
    adamfarley committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    fc2e29f View commit details
    Browse the repository at this point in the history

  4. Tidying IFs and fixing the arch capitalization 

    Signed-off-by: Adam Farley <adfarley@redhat.com>
    @adamfarley
    adamfarley committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    fcac5dc View commit details
    Browse the repository at this point in the history

  5. Adding square brackets to permit regex 

    Signed-off-by: Adam Farley <adfarley@redhat.com>
    @adamfarley
    adamfarley committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    81975da View commit details
    Browse the repository at this point in the history

  6. Debug messages 

    Signed-off-by: Adam Farley <adfarley@redhat.com>
    @adamfarley
    adamfarley committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    aa8d14e View commit details
    Browse the repository at this point in the history

  7. Adding another debug comment 

    Signed-off-by: Adam Farley <adfarley@redhat.com>
    @adamfarley
    adamfarley committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    9e550e7 View commit details
    Browse the repository at this point in the history

  8. Changing to lowercase to match previous behaviour 

    Signed-off-by: Adam Farley <adfarley@redhat.com>
    @adamfarley
    adamfarley committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    211c633 View commit details
    Browse the repository at this point in the history

  9. Remove debug statement

    @sxa
    sxa authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    33586d2 View commit details
    Browse the repository at this point in the history

  10. Remove debug statement

    @sxa
    sxa authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e3afec7 View commit details
    Browse the repository at this point in the history

  11. Remove debug statement

    @sxa
    sxa authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    f6f4d3e View commit details
    Browse the repository at this point in the history

  12. Remove debug statement

    @sxa
    sxa authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    14a209f View commit details
    Browse the repository at this point in the history