-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove xcode switch path commands from build scripts #2876
base: master
Are you sure you want to change the base?
Conversation
…fault in playbooks
Thank you for creating a pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM But please make sure the default is set correctly on all build machines before this is merged :-)
@sxa Done. And I dont seem to have permissions to merge this. Could you give me permissions, or could you merge this please. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jdk8u build
configure: error: Xcode 6, 9-12 is required to build JDK 8, the version found was 13.2.1. Use --with-xcode-path to specify the location of Xcode or make Xcode active by using xcode-select.
(Adjusted comment) @gdams is the github checks running in a completely differnet environment from the machies we have in jenkins in a way that this doesn't work for? Can we pre-select a default compiler in that environment? |
Yeah I've just pushed a commit |
Looks like the JDK11u build is genuinely broken after switching:
|
@gdams I was able to build jdk11 hotspot on build-macstadium-macos1014-x64-2 using the full xcode-select switch path
|
The build did not hit the same error as the github workflow
|
this has been stale for over a year, converting to "draft", if no longer needed please close. |
Ref https://adoptium.slack.com/archives/C09NW3L2J/p1646743526526249
From the above slack thread, it was determined that a full switch path,
/Applications/Xcode.app
, can be used for JDK11. Since it is already being used for 8 and 17+, It will be made the default switch path on our build machines via the playbooks (pr incoming). Therefore these commands will not be needed in the build scripts