Add BUILD_CONFIG[OS_FULL_VERSION] #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run tests |
andrew-m-leonard
force-pushed
the
osversion
branch
from
6c505f4
to
916ce49
Compare
sxa
requested changes
Jun 21, 2021
andrew-m-leonard
force-pushed
the
osversion
branch
from
916ce49
to
828400d
Compare
sxa
approved these changes
Jun 21, 2021
|
Approving on the assumption that my suggestions have been tested first ;-) |
|
sxa
reviewed
Jun 21, 2021
gdams
approved these changes
Jun 21, 2021
andrew-m-leonard
force-pushed
the
osversion
branch
from
828400d
to
003ff41
Compare
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
andrew-m-leonard
force-pushed
the
osversion
branch
from
003ff41
to
20c2580
Compare
karianna
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the "reproducible builds" issue: #2594 (comment)
the key piece of information missing from the built "BUILD_CONFIG" was the full os version level the binary was built on, this adds that info.
Signed-off-by: Andrew Leonard anleonar@redhat.com