Expand config parameter location explanation #2518
Conversation
* Further explains how and where shell script parameters should be injected * Follow on from adoptium#2506 * Part 2 of adoptium#2129 Signed-off-by: Morgan Davies <morgandavies2020@gmail.com>
M-Davies
added
enhancement
There was a problem hiding this comment.
This superficially looks like a good set of recommendations, but I'll hold off on approving until Monday as I'm quite tired just now. I do think it's something that most of the build team shoul dhave input to so might be good to circulate in #build for wider review and opinions, but this will be a great addition to the documentation so thanks for kicking it off!
There was a problem hiding this comment.
I'm not a fan of "jenkins machine style environment" as that's a bit vague. I'd suggest that the intention was to reference machines in the jenkins farm which were set up by ansible specifically so I'd recommend different wording explicitly pointing to the infra repo as per my suggested change.
Is it also worth including the table from #2129 (comment) about when each parameter takes effect as that may not be clear to new users.
We possibly have another piece of work to do to ensure that all variables are set in the "right" place according to these guidelines but this is a good start and we badly need this sort of guidance :-)
Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
Signed-off-by: Morgan Davies morgandavies2020@gmail.com