Add option to pass in openJ9 repo and branch #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add openj9 repo and branch - minor format change by running npm format Signed-off-by: renfeiw <renfeiw@ca.ibm.com>
renfeiw
requested review from
smlambert,
llxia and
sophia-guo
and removed request for
llxia
llxia
reviewed
Jun 7, 2021
| openj9_repo: | ||
| description: 'openj9 Repo' | ||
| required: false | ||
| default: 'openj9:master' |
There was a problem hiding this comment.
Should use the new repo? i.e., eclipse-openj9:master
There was a problem hiding this comment.
Talked with @renfeiw , this is used as a check. It is not used for constructing openj9 git repo url, so it does not need to be changed.
There was a problem hiding this comment.
openj9 is the OpenJ9 main code base under eclipse-openj9 : https://github.com/eclipse-openj9/openj9. I think openj9 is a correct one. Also I believe openj9_repo is set as the same way as two other repos do, which only use default as a flag. We actually don't need the default value as we can check if the parameter is empty or not. I will open a separate issue to do that.
llxia
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: renfeiw renfeiw@ca.ibm.com