Dynamic run for run-aqa GH action #130
Conversation
|
Just submitted the ECA. |
|
Since the release is upon us, I might turn this into a draft since I will need to point |
|
I believe I have addressed most comments raised to the best of my knowledge. Please let me know if there are any other changes required to get this across the finish line. Here is a run using my latest changes. Thanks!! 😄 |
|
@j-braley Looks like more failing GH Actions though. |
|
Updated GH action to run |
|
@karianna or @smlambert can I get an approval to run the extra GH actions? I made changes to the underlying action to run |
src/runaqa.ts
Outdated
|
|
||
| await setupTestEnv(version, jdksource, customizedSdkUrl, sdkdir, buildList, aqatestsRepo, openj9Repo, tkgRepo, vendorTestParams, aqasystemtestsRepo); | ||
| process.chdir('TKG'); | ||
| process.env.PARALLEL_OPTIONS = `PARALLEL_OPTIONS=TEST=${buildList} TEST_TIME= NUM_MACHINES=${numMachines}`; |
There was a problem hiding this comment.
TEST should equal to the test target.
There was a problem hiding this comment.
I believe BUILD_LIST here would be the target? Since the values of BUILD_LIST would be one of openjdk, functional, system, perf. Or am I mistaken? If the verbiage does not make sense that could be adjusted. However, I believe that this value matches what is set in the env variable BUILD_LIST.
There was a problem hiding this comment.
BUILD_LIST is not the target, it is the directory to be compiled. Some target and BUILD_LIST happen to share the same name, for example functional, but target also could be sanity.functional which is different from BUILD_LIST
There was a problem hiding this comment.
Thank you for the explanation. I will update the code.
|
Enable github action runs and wait for the results |
| * @param {string} jdksource Source for JDK | ||
| * @param {[string]} customizedSdkUrl Download link for JDK binaries | ||
| * @param {[string]} sdkdir Directory for SDK | ||
| * @param {[string]} buildList AQAvit Test suite |
There was a problem hiding this comment.
Could we also add @param target: string, customTarget: string ?
|
To make it easy to use/understand the example workflow can also be committed. As action.yml itself can not clearly demo how the feature is used. |
j-braley
requested review from
karianna,
sophia-guo and
smlambert
and removed request for
smlambert,
karianna and
sophia-guo
|
Apparently, I am learning that GitHub has limits on reviewers 😦 @sophia-guo so she can review as well. |
|
@j-braley you'll need to rebase again sorry! |
Addresses #125.
Adds in functionality to run tests in parallel. This is accomplished by having a new function generate
parallelList.mkand updating therunAqaTest()function run the suite of tests if the target includes-f parallelList.mk.Any GitHub action which leverages this action handles distributing the
parallelList.mkgenerated to child jobs (e.g., upload artifact/ download artifact).Please let me know any questions, comments, or concerns 😄!