initial step to add windows installer tests #630
Conversation
There was a problem hiding this comment.
Approving and while I forgot to mention this one in today's community call as nice to merge, calling it out to @steelhead31 as we are heading into 'code freeze' times. This PR has no impact on the release process (currently not called from the release pipelines at all), but helps facilitate to progress work to add msi testing (which is being done in a standalone job).
| export RESULTS_FOLDER=$1/result | ||
| export INPUT_FOLDER=$1/input | ||
|
|
||
| #mkdir $RESULTS_FOLDER |
test/functional/wintps/build.xml
Outdated
| <target name="getWinTPSTest" depends="wintpsTest.check" unless="wintpsTestdir.exists"> | ||
| <exec executable="git" failonerror="true"> | ||
| <arg value="clone" /> | ||
| <arg value="https://github.com/RadekCap/WindowsTPS" /> |
There was a problem hiding this comment.
Are we happy with the source of this lib?
There was a problem hiding this comment.
Good catch, that should now be updated to https://github.com/rh-openjdk/WindowsTPS
| #mkdir $RESULTS_FOLDER | ||
| mkdir $INPUT_FOLDER | ||
| export JDK_VERSION=$2 | ||
| export MSI_VENDOR="Adoptium" |
There was a problem hiding this comment.
Get this as a default but we should be able to pass in a vendor?
There was a problem hiding this comment.
Yes, as this is the initial step we will update that later with other enhancement.
Co-authored-by: Sophia Guo <sophia.gwf@gmail.com> Co-authored-by: Shelley Lambert <slambert@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
First step of #559
Co-authored-by: Sophia Guo sophia.gwf@gmail.com
Co-authored-by: Shelley Lambert slambert@gmail.com