Added functionality for testScript.sh to run a test on a built JDK #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxa
requested changes
Sep 20, 2019
| #!/bin/bash | ||
|
|
||
| mv /vagrant/pbTestScripts/workspace/build/src/build/linux-x86_64-normal-server-release/images/jdk8* ~ | ||
| export TEST_JDK_HOME=$(find ~ -maxdepth 1 -type d -name "*jdk8u*"|grep -v ".*jre.*") |
There was a problem hiding this comment.
Any reason not to just set TEST_JDK_HOME to /vagrant/pbTestScripts/workspace/build/src/build/linux-x86_64-normal-server-release/images/jdk8*?
There was a problem hiding this comment.
There's 2 directories in there- the JDK to test, and the JRE, which has the same name but -jre at the end
sxa
reviewed
Sep 30, 2019
sxa
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #939
Currently only implemented for the unix playbooks. If the option is specified, the script will run the
MachineInfotest against a version of JDK8 that is built on the VM, having been setup by the playbook. It won't allow a test to be ran unless a JDK is built.