Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronise hostnames in inventory.yml to jenkins host #634

Closed
wants to merge 1 commit into from
Closed

Synchronise hostnames in inventory.yml to jenkins host #634

wants to merge 1 commit into from

Conversation

HusainYusufali
Copy link
Contributor

The hostnames in the inventory.yml have been changed to match the hostnames in the jenkins inventory.

Fixes: #619

@HusainYusufali HusainYusufali mentioned this pull request Dec 11, 2018
Closed
gdams
gdams requested changes Dec 11, 2018
View reviewed changes
Copy link
Member

@gdams gdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't just change the naming here. It is used to set variables in ansible. A better approach would be to update the hosts to all use the schema defined here

@gdams
Copy link
Member

gdams commented Dec 14, 2018

closing as this is the wrong approach, we should work to update the hosts to all use the schema defined here

@gdams gdams closed this Dec 14, 2018
@HusainYusufali HusainYusufali deleted the sync_hosts branch December 14, 2018 19:44
@Willsparker Willsparker mentioned this pull request May 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdams gdams gdams requested changes

Assignees
No one assigned
Labels
enhancement invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HusainYusufali @gdams @karianna