-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnixPB: Add Fedora 40 Support #3761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this, but noting:
- are there any implications on older Fedora versions of completely removing
libnss3.so
here - I think that was added for some of the security tests. - Noting that in the
nasm
playbook we have a mix of syntax:ansible_distribution == "Ubuntu" and ansible_distribution_major_version < "22")
vs(ansible_distribution == "Ubuntu" and ansible_distribution_major_version | int >= 24)
. I definitely have a recollection - possibly ansible version specific - that one is better than the other so maybe we should standardise. I have a feeling it was the| int
version that was preferable but don't hold me to that :-)
For the currently supported versions of Fedora ( 39 & 40 ) the libnss3 libraries are installed via nss-devel & nss-util packages, so removing it has no impact on the currently supported versions. The vagrant playbook checks run the SSL tests as part of the TEST_JDK flag, so this would highlight any issues for the Fedora 40 run.
I've standardised this to be consistent for all the major version checks. I believe the int comparison is a more reliable comparison for numeric values, particularly as using <= with string operations is a bit inconsistent. the string operations are fine for a simple ==. |
@steelhead31 I guess this supercedes #3663? |
Yup, I hadnt seen the earlier one. |
Fixes #3599
Correct Unix playbooks to allow execution on Fedora 40.
Checklist
Fedora 40: VPC : https://ci.adoptium.net/job/VagrantPlaybookCheck/1974/
Ubuntu 22: VPC : https://ci.adoptium.net/job/VagrantPlaybookCheck/OS=Ubuntu2204,label=vagrant/1975/
Debian 10: VPC : https://ci.adoptium.net/job/VagrantPlaybookCheck/OS=Debian10,label=vagrant/1975/