Vagrant: Update Vagrant Host Playbook & Introduce 2 new Azure vagrant hosts for VPC / QEMU

[steelhead31]

Commision 2 new azure based hosts for running VPC / QEMU

Checklist

• commit message has one of the standard prefixes
• playbook changes run through VPC or QPC (if you have access)
• for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

[sxa]

Given the amount of updates here I feel this may be a PR where I decide to approve it based on the fact it's been tested rather than because I've reviewed in detail ;-)

[steelhead31]

VPC test runs : https://ci.adoptium.net/job/SFR-VPC-AZURE-POC/
 

Qemu test runs : https://ci.adoptium.net/job/SFRY-QEMU-POC/

[steelhead31]

Tested extensively here... https://ci.adoptium.net/job/SFR-VPC-AZURE-POC/

[Haroon-Khel]

Approving based on the tests

[sxa]

A couple of initial comments:

• Can we add a description of the new python script perhaps with basic usage info as comments at the top?
• It looks like we're installing JDK17 on the machine - assuming this is just for the jenkins agent process can we bump to 21 and install via the API to ensure we get the latest version of 21?

[steelhead31]

A couple of initial comments:

• Can we add a description of the new python script perhaps with basic usage info as comments at the top?
• It looks like we're installing JDK17 on the machine - assuming this is just for the jenkins agent process can we bump to 21 and install via the API to ensure we get the latest version of 21

@sxa 

I've removed the new python script, I rewrote this to run via vagrant rm, so its quicker and it retains its visible activity output facility.

I've bumped the JDK installation from JDK17 to JDK21, installed via the API. Playbook has been run on both new hosts to install the new JDK, Jenkins has been updated accordingly.

[steelhead31]

New test running here : https://ci.adoptium.net/job/SFR-VPC-AZURE-POC/48/

[steelhead31]

New test run in progress with changes following review comments... https://ci.adoptium.net/job/SFR-VPC-AZURE-POC/49/

[sxa]

Ref:

- name: Set VirtualBox extension pack license agreement

I assume we've looked at it and there's nothing of concern in there before auto-accepting this?

echo "DEBUG - SF01"

These should be removed. I assume you already plan to do this but I just wanted to make sure it was still blocked until the change has been made, hence leaving my review as "Request changes" :-)

v.customize ["modifyvm", :id, "--cpuexecutioncap", "80"]

Bumping this from 50 to 80 makes me a little nervous as it could overwhelm machines that are running with multiple executors, potentially leading to timeouts in the runs. I'm willing to give it a shot if you think it'll be "safe" but we should keep an eye on it.

[sxa]

As another point - have you tested a machine set up this way with QPC as well as VPC to see if that still works?

[steelhead31]

@sxa QPC runs are here: https://ci.adoptium.net/job/SFRY-QEMU-POC/, they behave similar to the real ones :)

The debug is something Im working on now ( trying to rationalise the playbook execution statement, but its being problematic)

I've reverted the CPU cap, again its been left in from my local testing.. its fine with 50 on the remote host :)

[steelhead31]

@sxa I've removed the extpack license agreement, and uninstalled it. Thanks for the heads up

[steelhead31]

Reverting to draft, whilst I fix up the playbook execution

[steelhead31]

CPU cap at 50% isnt sufficient for the azure boxes, but 60% is, so I've bumped it to that, if needed, we can look to change this again, once the large vagrant host has been rebuilt.

[steelhead31]

I think I've addressed all the review comments, new test runs are here, https://ci.adoptium.net/job/SFR-VPC-AZURE-POC/OS=Solaris10,label=vagrantX/55/console , https://ci.adoptium.net/job/SFR-VPC-AZURE-POC/58/OS=CentOS8,label=vagrantX/console & https://ci.adoptium.net/job/SFR-VPC-AZURE-POC/60/OS=Win2022,label=vagrantX/console

[sxa]

Assuming it passes your tests I reckon I'm ok with this now :-)

Problem resolved.