-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vagrant: Improve VPC Performance For Windows Server 2022 #3644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karianna
requested changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look broadly good but suspect tabs vs spaces or some such...
karianna
approved these changes
Jul 3, 2024
karianna
approved these changes
Jul 3, 2024
gdams
approved these changes
Jul 3, 2024
sxa
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3553
Due to poor performance of the Windows Server 2022 vagrant playbook check job, this PR makes a number of improvements to reduce the time taken to build, notably these are:
The addition of the "Use Adoptium Box" option, this has only been implemented (currently) for Windows 2022, and when selected will switch the VPC job from using the standard Vagrantfile.Win2022 file, to using the Vagrantfile.Win2022.Adopt file. This 2nd new vagrantfile uses an Adoptium specific vagrant box ( stored on the vagrant server but also imported to all the VPC hosts vagrant boxes ). This vagrant box, is a fully updated ( as of 25th June ) Windows Server 2022 install, so the windows update task in the playbook is much quicker.
The 2nd major change, is the selective install of MSVS versions based on the JDK version selected, ( this requires the selection of the fast mode option )
JDK8 will limit the playbook to only installing MSVS_2013
JDK11 will limit the playbook to only installing MSVS_2017
JDK17 will limit the playbook to only installing MSVS_2019
JDK21/JDK22 and JDK head will limit the playbook to only installing MSVS_2022