Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrant: Improve VPC Performance For Windows Server 2022 #3644

Merged
merged 13 commits into from
Jul 3, 2024

Conversation

steelhead31
Copy link
Contributor

Fixes #3553

Due to poor performance of the Windows Server 2022 vagrant playbook check job, this PR makes a number of improvements to reduce the time taken to build, notably these are:

  1. The addition of the "Use Adoptium Box" option, this has only been implemented (currently) for Windows 2022, and when selected will switch the VPC job from using the standard Vagrantfile.Win2022 file, to using the Vagrantfile.Win2022.Adopt file. This 2nd new vagrantfile uses an Adoptium specific vagrant box ( stored on the vagrant server but also imported to all the VPC hosts vagrant boxes ). This vagrant box, is a fully updated ( as of 25th June ) Windows Server 2022 install, so the windows update task in the playbook is much quicker.

  2. The 2nd major change, is the selective install of MSVS versions based on the JDK version selected, ( this requires the selection of the fast mode option )

JDK8 will limit the playbook to only installing MSVS_2013
JDK11 will limit the playbook to only installing MSVS_2017
JDK17 will limit the playbook to only installing MSVS_2019
JDK21/JDK22 and JDK head will limit the playbook to only installing MSVS_2022

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look broadly good but suspect tabs vs spaces or some such...

ansible/pbTestScripts/vagrantPlaybookCheck.sh Outdated Show resolved Hide resolved
ansible/pbTestScripts/vagrantPlaybookCheck.sh Outdated Show resolved Hide resolved
ansible/vagrant/Vagrantfile.Win2022.Adopt Outdated Show resolved Hide resolved
@steelhead31 steelhead31 requested a review from karianna July 2, 2024 12:29
ansible/pbTestScripts/vagrantPlaybookCheck.sh Outdated Show resolved Hide resolved
ansible/pbTestScripts/vagrantPlaybookCheck.sh Outdated Show resolved Hide resolved
ansible/pbTestScripts/vagrantPlaybookCheck.sh Outdated Show resolved Hide resolved
@steelhead31 steelhead31 merged commit 4b3b5ae into adoptium:master Jul 3, 2024
9 checks passed
@steelhead31 steelhead31 deleted the vpc_win_perf branch July 3, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows 2022 VagrantPlaybookCheck jobs are taking 11 hours
4 participants