Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update FAQ to mention aqa-tests branches #3564

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented May 14, 2024

Based on things seen in:

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa sxa added this to the 2024-05 (May) milestone May 14, 2024
@sxa sxa self-assigned this May 14, 2024
@github-actions github-actions bot added the doc label May 14, 2024
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style suggestion (active voice) - could change to:

then the process is typically like this. To avoid the test material not
matching the JDK under test which can lead to false failures when you're
testing a build which isn't the latest (such as a previous GA/the last release),
it is recommended that you check out the appropriate branch for the last release
from the aqa-tests repository in the first line here.

Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa
Copy link
Member Author

sxa commented May 15, 2024

Style suggestion (active voice) - could change to:

I have no preference, so I've switched the wording to what you've recommended.

@gdams gdams merged commit 137a3f3 into adoptium:master Jul 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants