Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPB: Clean_Up role: remove warn: no #3428

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Conversation

sxa
Copy link
Member

@sxa sxa commented Feb 29, 2024

This syntax is invalid and does not work with the new AWX server
Fixes #3425

While there may be a better solution here, this will allow the deployments to continue to succeed ... I've tested this in a separate AWX template

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Signed-off-by: Stewart X Addison <sxa@redhat.com>
@karianna
Copy link
Contributor

karianna commented Mar 4, 2024

@sxa Looks like various checks failed

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxa
Copy link
Member Author

sxa commented Mar 4, 2024

@sxa Looks like various checks failed

None of those seem related to the PR and are failures earlier on in the checks - would you agree?

@steelhead31
Copy link
Contributor

@sxa Im just working on the fix for the labeler :)

@karianna
Copy link
Contributor

karianna commented Mar 5, 2024

GH action failures are unrelated.

@karianna karianna merged commit 031e042 into adoptium:master Mar 5, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWX: Unsupported parameters in Clean_Up role
3 participants