-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbreak aarch64 dockerbuild under Ubuntu 22.04 #3398
Conversation
Signed-off-by: Stewart X Addison <sxa@redhat.com>
6dfb2eb
to
3e78e10
Compare
@sxa just linter fixes to go? |
I don't think they're related to my PR given that I'm just deleting a line in a Dockerfile here. I'm checking on my phone but it looks like it's objecting to solve indenting in an ansiblr playbook |
Yeah, I think it's an easy enough fix if you don't mind updating it when you get to your machine? |
There are a LOT of fixes that it needs and I do feel that these sorts of changes render the "Blame" history useless for all changed lines. Unclear sure why these have just been flagged - I'm somewhat tempted to just switch them off but I'll do a separate PR for them with these comments. |
So we trigger the linter checkes (including yamllint) when there are changes in the ansibel directory but not |
Well that's something I've never seen before but now intrigued to trial it in this repository ... |
@karianna I genuinely have no idea why but I just re-ran the failing checks and it passed, so my other PR isn't strictly necessary now ... |
Checklist
This line should only ever have been in the ubuntu 16.04 one as it's the image we use for arm32. Anyone building a later image should have it able to work on aarch64.