Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak aarch64 dockerbuild under Ubuntu 22.04 #3398

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Feb 15, 2024

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

This line should only ever have been in the ubuntu 16.04 one as it's the image we use for arm32. Anyone building a later image should have it able to work on aarch64.

Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa sxa force-pushed the unbreak_aarch64_dockerbuild branch from 6dfb2eb to 3e78e10 Compare February 15, 2024 16:44
@github-actions github-actions bot added ansible and removed ansible labels Feb 15, 2024
@karianna
Copy link
Contributor

@sxa just linter fixes to go?

@sxa
Copy link
Member Author

sxa commented Feb 17, 2024

@sxa just linter fixes to go?

I don't think they're related to my PR given that I'm just deleting a line in a Dockerfile here. I'm checking on my phone but it looks like it's objecting to solve indenting in an ansiblr playbook

@karianna
Copy link
Contributor

Yeah, I think it's an easy enough fix if you don't mind updating it when you get to your machine?

@sxa sxa changed the title Unbreak aarch64 dockerbuild Unbreak aarch64 dockerbuild under Ubuntu 22.04 Feb 19, 2024
@sxa
Copy link
Member Author

sxa commented Feb 19, 2024

Yeah, I think it's an easy enough fix if you don't mind updating it when you get to your machine?

There are a LOT of fixes that it needs and I do feel that these sorts of changes render the "Blame" history useless for all changed lines. Unclear sure why these have just been flagged - I'm somewhat tempted to just switch them off but I'll do a separate PR for them with these comments.

@sxa sxa mentioned this pull request Feb 19, 2024
6 tasks
@sxa
Copy link
Member Author

sxa commented Feb 19, 2024

So we trigger the linter checkes (including yamllint) when there are changes in the ansibel directory but not .github which means that when the yaml files are updated the checks aren't run on them, but the checks appear to be running against them, so the other PR isn't actually running the checks at present ... Not the Monday morning I had in plan 🤣

@sxa
Copy link
Member Author

sxa commented Feb 19, 2024

render the "Blame" history useless for all changed lines

Well that's something I've never seen before but now intrigued to trial it in this repository ...
https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view

@sxa
Copy link
Member Author

sxa commented Feb 19, 2024

@karianna I genuinely have no idea why but I just re-ran the failing checks and it passed, so my other PR isn't strictly necessary now ...

@karianna karianna merged commit 2baf5f6 into adoptium:master Feb 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants