Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Use secret for ROSIPW on RHEL7 build dockerfile #3320

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Jan 3, 2024

Current process exposes the ROSI credential in the docker image. This switches the process to use a secret supplied in an environment variable as per https://docs.docker.com/build/building/secrets

Another option would be to use a secret file (e.g. secret id=ROSPIW,src=$HOME/.rosipw) but that runs a great risk of being accessed if cleanup does not occur properly.

Draft while testing is performed, but reviews welcome in the meantime

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa sxa self-assigned this Jan 3, 2024
@github-actions github-actions bot added the docker label Jan 3, 2024
@sxa
Copy link
Member Author

sxa commented Jan 3, 2024

Ran into various weird certificate problems using the old version of the docker image I had on the machine (sha256:0d98d4a2076fbf871a4854f05f2f83ee673cc619e6a741edde9886771561fc13). The new one (sha256:7df1d6982eed0c3ce48699b9a9fb0dcb3706db5417a87bda6f9a916a9e0a8bf8) does not exhibit the same problem, so I believe this is good to go. Removing from draft.

@sxa sxa marked this pull request as ready for review January 3, 2024 16:30
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steelhead31 steelhead31 merged commit d2303c7 into adoptium:master Jan 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants