docker: Use secret for ROSIPW on RHEL7 build dockerfile #3320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current process exposes the ROSI credential in the docker image. This switches the process to use a secret supplied in an environment variable as per https://docs.docker.com/build/building/secrets
Another option would be to use a secret file (e.g.
secret id=ROSPIW,src=$HOME/.rosipw
) but that runs a great risk of being accessed if cleanup does not occur properly.Draft while testing is performed, but reviews welcome in the meantime
Checklist