Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github: Update Docker Login Credentials To Use Token #3297

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

steelhead31
Copy link
Contributor

@steelhead31 steelhead31 commented Dec 13, 2023

Fixes #3211

Update docker credentials to use PAT, but disable push on merge, due to replacement with docker multiarch jenkins job. Code left to enable easy re-enablement if required.

The docker push on merge has also been disabled, due to the relocation of the centos6 docker push to the jenkins job as per this PR: #3296

Checklist

Update docker credentials to use PAT, but disable push on merge, due to replacement with docker multiarch jenkins job. Code left to enable easy re-enablement if required.
@github-actions github-actions bot added the ghActions GitHub Actions label Dec 13, 2023
@steelhead31 steelhead31 requested a review from sxa December 14, 2023 10:10
@steelhead31 steelhead31 marked this pull request as ready for review December 14, 2023 11:09
Copy link
Contributor

@Haroon-Khel Haroon-Khel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also in favour of the image push being in Jenkins instead of github workflow, since the Jenkins job is triggered everytime a pr is merged anyway. No need to push the same image twice

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do a one-off run with push: true to verify that the functionality works as expected, but I'm ok for this to go in regardless since we're switching to using the jenkins job like we do for the other ones.

Ref: https://github.com/docker/login-action/blob/master/README.md#docker-hub (Tokens seem valid in the password field)
Ref: #3296
Also noting that with these changes we should update https://github.com/adoptium/infrastructure/blob/master/FAQ.md#what-about-the-builds-that-use-the-dockerbuild-tag which talks about where the various images are built

@steelhead31 steelhead31 merged commit f046fee into adoptium:master Dec 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ghActions GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adoptium Centos 6 docker build image in docker hub not updated since last 9 months
3 participants