Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windowsPb: Add missing when condition to MSVS_2019 install #3244

Merged
merged 2 commits into from
Nov 8, 2023
Merged

windowsPb: Add missing when condition to MSVS_2019 install #3244

merged 2 commits into from
Nov 8, 2023

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Nov 7, 2023 •
edited
Loading

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

The playbook will attempt to get a sha checksum of a file that is not present (because msvs2019 is already installed) causing the playbook to fail

"stderr": "Resolve-Path : Cannot find path 'C:\\TEMP\\VS2019_Layout.zip' because it does \r\nnot exist.

@Haroon-Khel Haroon-Khel mentioned this pull request Nov 7, 2023
Closed
@Haroon-Khel
Copy link
Contributor Author

Works as expected https://awx2.adoptopenjdk.net/#/jobs/playbook/2087?job_search=page_size:20;order_by:-finished;not__launch_type:sync

@Haroon-Khel
Copy link
Contributor Author

ping @steelhead31 for review

steelhead31
steelhead31 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haroon-Khel Haroon-Khel merged commit 2eed41c into adoptium:master Nov 8, 2023
8 checks passed
This was referenced Nov 9, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steelhead31 steelhead31 steelhead31 approved these changes

@sxa sxa sxa approved these changes

Assignees
No one assigned
Labels
ansible os:windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Haroon-Khel @sxa @steelhead31