Update installed JDKs to match current boot JDK requirements #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxa
changed the title
|
This is going to require a bit more work because it's trying to pull JDK20 from api.adoptopenjdk.net which does not redirect to adoptium, so this will stay in draft for now until it can be progressed. |
|
On hold until we come up with something sane to do for Linux on s390x and arm32 |
sxa
force-pushed
the
jdk20_install
branch
3 times, most recently
from
f4644aa
to
b240053
Compare
|
@sxa Needs a rebase |
adamfarley
requested changes
Mar 8, 2024
There was a problem hiding this comment.
Most of it LGTM. 2 concerns:
- Various Yaml Lint and Ansible lint failures. The latter seem to be caused by the "---" being before the first comment block in a few files, as the error doesn't seem to pop up when the "---" is after the first comment block.
- Lines 190 and 223 in ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/adoptopenjdk_install/tasks/main.yml look like a merge has gone wrong. Pls fix thnx. :)
sxa
force-pushed
the
jdk20_install
branch
3 times, most recently
from
38d7188
to
afba496
Compare
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
|
CentOS6 and Solaris also now clean (Both have special paths in this particular role at present. |
adamfarley
reviewed
Mar 11, 2024
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/adoptopenjdk_install/tasks/main.yml
Outdated
Show resolved
Hide resolved
…k_install/tasks/main.yml Removing double space
adamfarley
reviewed
Mar 11, 2024
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/adoptopenjdk_install/tasks/main.yml
Outdated
Show resolved
Hide resolved
adamfarley
reviewed
Mar 11, 2024
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/adoptopenjdk_install/tasks/main.yml
Outdated
Show resolved
Hide resolved
…k_install/tasks/main.yml Lining up comment hashes.
…k_install/tasks/main.yml Lining up comment hashes.
|
And thanks for handling all those linter changes. :) |
|
Merging so that it's ready for the JDK22 dry run pipelines later this week. |
|
Rebuild of linux images happening under https://ci.adoptium.net/job/centos7_docker_image_updater/471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Draft pending VPC checks and verification that the build uses the installed JDK20 but approvals welcome in the meantime.