Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnixPb: CentOS8 Updates #3040

Merged
merged 1 commit into from
Aug 15, 2023
Merged

UnixPb: CentOS8 Updates #3040

merged 1 commit into from
Aug 15, 2023

Conversation

vsebe
Copy link
Contributor

@vsebe vsebe commented Apr 25, 2023

Use dnf config-manager to enable powertools repo.
Fix libdwarf package name.

Checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna
Copy link
Contributor

Assume solaris failure is separate

@AdamBrousseau
Copy link
Contributor

Bumping this so we can close it off on our end.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching up with some old PRs. @vsebe Can you update the commit message to be more descriptive about what it's doing (e.g. "Fix libdwarf install on non-x64" or similar.

Also is the powertools a prereq for the libdwarf install or is the reason for that separate?

Use dnf config-manager to enable powertools repo.
Fix libdwarf package name.

Signed-off-by: Violeta Sebe <vsebe@ca.ibm.com>
@vsebe
Copy link
Contributor Author

vsebe commented Jun 8, 2023

Comment updated.
The powertools repo is a prereq for the libdwarf install on aarch64.

@sxa
Copy link
Member

sxa commented Jun 8, 2023

/thaw

@github-actions github-actions bot dismissed their stale review June 8, 2023 17:43

Pull Request unblocked - code freeze is over.

@sxa
Copy link
Member

sxa commented Jun 9, 2023

CentOS6 test failed but it may not be related to this PR so I'm re-running to see if it's repeatable.

@AdamBrousseau
Copy link
Contributor

Bumping this to try and get it closed out. Thanks.

@sxa sxa merged commit 2bf767c into adoptium:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants