Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins: Add centos6 build job to centos7_docker_image_updater jenkins job #2756

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Sep 29, 2022

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref #2753

If we're using this job to push the centos6 image to dockerhub, then am I correct to assume that we then do not have to push the image to dockerhub during the github workflow

build-and-push-centos6:
, and just use the pr workflow as a test?

@gdams
Copy link
Member

gdams commented Sep 29, 2022

@Haroon-Khel is there a reason to make this change? GitHub actions is a more stable environment and works well for pushing the Centos 6 job where we only need intel machines. I used Jenkins because we had to build arm64 etc for Centos 7

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Sep 30, 2022

@gdams It was really out of a desire to have the these build jobs in one place. In terms of stability, im trying to get the jenkins job to become more stable, #2760, so after i've got it running green(er) it might make more sense to have the centos6 build job running there than in the workflow

@steelhead31 steelhead31 self-requested a review February 6, 2023 13:07
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steelhead31 steelhead31 merged commit 4644e19 into adoptium:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants