-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unixPB: add new dockerstatic container for Redhat UBI8 #2532 #2557
Conversation
@steelhead31 Ref what Haroon said earlier, did you manage to get this Dockerfile to work without tripping up on Xvfb/epel? |
Yes, I've just checked my local container from my development, and this command works... yum -y install xorg-x11-server-Xvfb however I did notice doing a yum install in the container appears to pick up my locally configured repos... Let me do a little more testing, by removing my local repos, and recreating the container. |
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/DockerStatic/Dockerfiles/Dockerfile.ubi8
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/DockerStatic/Dockerfiles/Dockerfile.ubi8
Show resolved
Hide resolved
@steelhead31 Hmmm doesn't seem to work for me as it fails to install epel and then fails to install Xvfb:
|
Tried it again, it definitely works ok.. built an image from the dockerfile, ran a container up, and XVFB is installed.. [root@e00edf570dcb /]# yum -y install xorg-x11-server-Xvfb @sxa its still picking up my CSB laptops repos... I'll tweak the dockerfile to either add the repos, or more likely do a manual install via wget .. would you mind testing the new dockerfile? , before I commit the changes again. |
Yeah I'll try and fit it in before my meeting-a-thon this afternoon :-) |
Updated the URL for api adoptium.net, and added additional repos to provide package dependencies.
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/DockerStatic/Dockerfiles/Dockerfile.ubi8
Show resolved
Hide resolved
@sxa The fix is in my requested changes. The x11 packages installs fine after installing the centos 8 stream repo that way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the changes in the latest commit, the container builds just fine.
I've create a new jenkins node for it here https://ci.adoptopenjdk.net/computer/test-docker-ubi8-x64-1/. Running a sanity test here: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4642/console
Merge after the grinder runs to completion
java/lang/ProcessHandle/InfoTest.java.InfoTest failed, but this may be specific to ubi8. I'm happy to merge this since the container is up and running, and any test failures can be investigated in a separate issue. @karianna still needs an approve from you I think |
That failure should be looked into if it's repeatable on this machine and not others - can you get any more info our of the test other that it threw an exception? |
Fixes #2532 |
@sxa / @Haroon-Khel .. it appears this may be a known issue.. whilst doing some investigating I came across this... |
Hmmm I don't think UBI should be running tools like sleep through busybox which appears to be what that issue is talking about. |
Yes, I was thinking more the coreutils, but if not the same root cause, possibly a similar symptom, in that the spawned process doesnt have the expected ID. |
Hmmm yes fairly reproducible outside java on UBI:
|
#sxa Replacing the ubi9 coreutils-single with the regular coreutils, makes the sleep command behave normally in its subprocess, can I get access to the dockerhost/container to test a fix... basically I want to run this command on the container yum install -y coreutils --allowerasing and then retry the grinder tests, alternatively @Haroon-Khel , would you mind doing this ?.. if this does work, its a minor change to the dockerfile. |
PMd you with the info you need to reproduce ;-) |
This latest commit fixes the LANG_0 & LANG_1 test failures.. here in grinder.. https://ci.adoptopenjdk.net/job/Grinder/4785/console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
Checklist