-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LJC codesign certs from all machines #2203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this in principle but it might be worth waiting until we're a little further down the Adoptium route before merging and deploying. We should also verify whether this will impact other teams using our stuff as we wouldn't want to risk destabilising others that might be relying on those certificates. Tagging @AdamBrousseau (I'm not sure if you're using any of the signing mechanisms that will be affected by this) for a review before accepting this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up Stewart. After review I think we should be fine with this change. We use a different mechanism now to sign our mac & win builds.
Vagrant run is erroring on: /opt/vagrant/embedded/gems/2.2.16/gems/vagrant-2.2.16/lib/vagrant/patches/net-ssh.rb:10:in |
The vagrant failure is on the Solaris check. I wouldnt think it would be associated with this pr. Either way, ive kicked off another job |
@Haroon-Khel What was the other job? Was it a re-run of the Solaris check or something else? |
@sxa A re run of the Solaris check. It still fails with the same error. As discussed in Slack, we agreed that the failure does not concern this pr. Is it safe to merge then? |
I'd say this is safe to merge. @sxa please approve and merge |
We no longer need these codesign certs. The safest option is to fully remove them from the machines to prevent us signing an Adoptium build with the wrong cert
Checklist