Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inv: Update build machines to be inline w/Jenkins #1334

Merged
merged 3 commits into from
May 26, 2020

Conversation

Willsparker
Copy link
Contributor

Ref: #619

Noticed whilst working on #1001 that the inventory.yml isn't particularly in sync with the node list at ci.adoptopenjdk.net/computer. This PR is to try and clean it up for the build machines. I've added the build machines that are ping-able and connected to Jenkins but not in inventory.yml, (from this list: #1001 (comment)). I also rearranged the order as to make sure they are alphabetical, and made sure their names are correct.
The build-linaro-centos76-armv8-1 machine has been removed as we no longer have it, looking at ci.adoptopenjdk.net/computer

@Willsparker Willsparker requested review from karianna and sxa May 20, 2020 11:45
@Willsparker Willsparker self-assigned this May 20, 2020
@Willsparker
Copy link
Contributor Author

Ref: The last commit.

Given that the arch armv8l didn't pass linting, I've changed it to armv8. I assume this should also be changed in the Jenkins node list too?

@Willsparker
Copy link
Contributor Author

I'm not sure why Travis isn't liking build-marist-rhel77-s390x-1 or the spearhead provider. Any idea @sxa ?

@karianna karianna added this to the May 2020 milestone May 24, 2020
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karianna
Copy link
Contributor

[DEPRECATION WARNING]: DEFAULT_SQUASH_ACTIONS option, Loop squashing is 
deprecated and this configuration will no longer be used , use a list directly 
with the module argument instead. This feature will be removed in version 2.11.
 Deprecation warnings can be disabled by setting deprecation_warnings=False in 
ansible.cfg.
[WARNING]:  * Failed to parse /home/travis/build/AdoptOpenJDK/openjdk-
infrastructure/ansible/plugins/inventory/adoptopenjdk_yaml.py with script
plugin: Inventory script (/home/travis/build/AdoptOpenJDK/openjdk-
infrastructure/ansible/plugins/inventory/adoptopenjdk_yaml.py) had an execution
error: Traceback (most recent call last):   File
"/home/travis/build/AdoptOpenJDK/openjdk-
infrastructure/ansible/plugins/inventory/adoptopenjdk_yaml.py", line 197, in
<module>     main()   File "/home/travis/build/AdoptOpenJDK/openjdk-
infrastructure/ansible/plugins/inventory/adoptopenjdk_yaml.py", line 116, in
main     raise Exception('Failed to parse host: %s' % e) Exception: Failed to
parse host: Invalid provider: spearhead
[WARNING]:  * Failed to parse /home/travis/build/AdoptOpenJDK/openjdk-
infrastructure/ansible/plugins/inventory/adoptopenjdk_yaml.py with ini plugin:
/home/travis/build/AdoptOpenJDK/openjdk-
infrastructure/ansible/plugins/inventory/adoptopenjdk_yaml.py:25: Expected
key=value host variable assignment, got: argparse
[WARNING]: Unable to parse /home/travis/build/AdoptOpenJDK/openjdk-
infrastructure/ansible/plugins/inventory/adoptopenjdk_yaml.py as an inventory
source
[WARNING]: No inventory was parsed, only implicit localhost is available
[WARNING]: Could not match supplied host pattern, ignoring: build-marist-
rhel77-s390x-1

@Willsparker
Copy link
Contributor Author

I noticed the error message about build-marist-rhel77-s390x-1 not being parsed was due to adoptopenjdk_yaml.py failing, as it didn't like the spearhead provider, so I've added that in :-)

@karianna karianna merged commit 6e50a45 into adoptium:master May 26, 2020
@Willsparker Willsparker deleted the inv branch June 18, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants