-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnixPB: Add Zulu7 for JDK8 Build bootstrap, make buildJDK.sh use JDK7 #1325
Conversation
FYI, zulu-7 is installed using the shell module, using
|
https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/573/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to only install this where the distribution doesn't have it's own openjdk7 available - can we adjust the conditionals accordingly to only put this on the recent distros that have it?
With the latest commit, the PR has include fairly significant changes to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes won't take effect on e.g. Ubuntu 20.04 - can we change the version conditionals to be >
or >=
comparisons please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref the issues with unarchive
I don't believe we need to install zulu-7 on any distributions which have such an old version of python, and since we've now restricted the distributions which this role runs on, we should probably switch it back to use the unarchive
role instead of the shell
operation
https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/581/OS=SUSE12,label=infra-vagrant-1/console |
Between https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/OS=CentOS8,label=infra-vagrant-1/584/ |
ref: adoptium/temurin-build#1732
Add in Zulu-7 to Unix playbook, as it can be a consistent JDK-7 amongst all the distributions, as some new linux distros are unable to install
openjdk-7
with their package manager.