Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnixPB: Installer role and playbook #1318

Merged
merged 2 commits into from
May 20, 2020

Conversation

Haroon-Khel
Copy link
Contributor

Ref #1283

Includes a role, installer, which installs the prerequisite build tools for the linux installer job, and a playbook, installer-setup.yml, which runs this role alongside the Jenkins_User and Superuser role to configure machines to be able to execute the Linux installer Jenkins job.

Tested by running Rpm and Deb build tasks, see https://github.com/AdoptOpenJDK/openjdk-installer/tree/master/linux#deb-packages, on a ubuntu 18.04 machine on which the playbook had been run. Build tasks were successful

@Haroon-Khel
Copy link
Contributor Author

Currently only supports Ubuntu 18.04 on x86

Copy link
Contributor

@Willsparker Willsparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on U18 Vagrant VM. Playbook went through fine :-)

@karianna karianna added this to the May 2020 milestone May 11, 2020
@gdams
Copy link
Member

gdams commented May 12, 2020

Is there a reason that you don't just want to install these dependencies on all our build machines?

creating an additional playbook for this seems like overkill IMO

@karianna
Copy link
Contributor

Is there a reason that you don't just want to install these dependencies on all our build machines?

creating an additional playbook for this seems like overkill IMO

I think it's about using Ansible to be able to replicate installing those dependencies if we lose machines?

@sxa
Copy link
Member

sxa commented May 12, 2020

@gdams it was more around any signing keys/authentication tokens etc. - while that can be done using jenkins secrets, we're not currently doing that and from a security/paranoia perspective I'm more keen to do this on machines we can keep a bit more locked down.

@karianna I believe George was suggesting adding them into the main build/test playbooks as opposed to objecting to adding this stuff into the playbooks at all.

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented May 13, 2020

@gdams I included the linux_installer_setup.yml playbook in the case where we need a sole machine for the linux installer Jenkins job, but if its considered overkill I can remove it.
I still feel that it would be convenient to have the role which installs only the linux installer prerequisites, as per #1283 (comment), since this role can be included in the main Unix playbook if needed.

@Willsparker
Copy link
Contributor

@Haroon-Khel I'd agree with having the individual role in the main playbook (personally)- as that would keep consistency with the Windows playbook ( https://github.com/AdoptOpenJDK/openjdk-infrastructure/blob/master/ansible/playbooks/AdoptOpenJDK_Windows_Playbook/roles/WiX/tasks/main.yml ).

@sxa
Copy link
Member

sxa commented May 18, 2020

@Haroon-Khel Have you been able to verify whether a setup done with this playbook is suitable for running all the operations in the install jobs or does that still have to be verified?

@Haroon-Khel
Copy link
Contributor Author

Ive tested only the gradle tasks buildDebPackage and buildRpmPackage. I wasnt able to test the upload tasks as I do not have access to the artifactory user and password

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to let this one in for now. If we can subsequently look at whether the keys can be made adequately secure then we can revist adding this into the main pipelines, but this is the less risky option for now.

@sxa sxa merged commit 51993f7 into adoptium:master May 20, 2020
@Haroon-Khel Haroon-Khel deleted the installer.playbook branch February 19, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants