Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade one x64 dockerhost to ubuntu 24.04 #3693

Closed
Tracked by #3588
sxa opened this issue Aug 1, 2024 · 7 comments
Closed
Tracked by #3588

Upgrade one x64 dockerhost to ubuntu 24.04 #3693

sxa opened this issue Aug 1, 2024 · 7 comments

Comments

@sxa
Copy link
Member

sxa commented Aug 1, 2024

Now that we have Ubuntu 24.04 we should look at upgrading one of the x64 dockerhost systems up to this level as it is the latest LTS and likely to be consistent with the kernel version that many people will now be using. This will also support the requirements of #3498.

I would naively suggest we do this with dockerhost-azure-ubuntu2204-x64-2 purely because it will keep the name of ubuntu2204-x64-1 "reasonable" (if we upgraded -1 we'd be leaving a 2204-x64-2 without a -1 which always looks a bit odd ...)

Part of #3588

@sxa sxa added the ansible label Aug 1, 2024
@sxa sxa changed the title Ansible request for <affected product> Upgrade one x64 dockerhost to ubuntu 24.04 Aug 1, 2024
@Haroon-Khel Haroon-Khel self-assigned this Aug 12, 2024
@Haroon-Khel
Copy link
Contributor

dockerhost-azure-ubuntu2204-x64-2 has been upgraded to dockerhost-azure-ubuntu2404-x64-1. Its hw.dockerhost labels have been updated. The upgrade went smoothly, no errors

@sxa
Copy link
Member Author

sxa commented Aug 12, 2024

Awesome! Can you install qemu-user-static on it if it's not already there and see if the jdk11u/riscv64 build will run on it?
Ref: #3498 (comment)

@Haroon-Khel
Copy link
Contributor

https://ci.adoptium.net/job/build-scripts/job/jobs/job/evaluation/job/jobs/job/jdk11u/job/jdk11u-evaluation-linux-riscv64-temurin/39/console failed

13:29:47  Compiling 7 properties into resource bundles for jdk.jshell
13:29:47  Compiling 13 properties into resource bundles for jdk.javadoc
13:29:47  /home/jenkins/workspace/build-scripts/jobs/evaluation/jobs/jdk11u/jdk11u-evaluation-linux-riscv64-temurin/workspace/build/src/build/linux-riscv64-normal-server-release/hotspot/variant-server/support/adlc/all-ad-src.ad(0) Semantic Error: :File read error, no input read
13:29:47  
13:29:47  gmake[3]: *** [gensrc/GensrcAdlc.gmk:182: /home/jenkins/workspace/build-scripts/jobs/evaluation/jobs/jdk11u/jdk11u-evaluation-linux-riscv64-temurin/workspace/build/src/build/linux-riscv64-normal-server-release/hotspot/variant-server/support/adlc/_adlc_run.marker] Error 1
13:29:47  gmake[3]: *** Waiting for unfinished jobs....
13:29:53  gmake[2]: *** [make/Main.gmk:265: hotspot-server-gensrc] Error 2
13:29:53  gmake[2]: *** Waiting for unfinished jobs....
13:29:53  Compiling 117 files for BUILD_java.compiler.interim
13:30:06  Compiling 394 files for BUILD_jdk.compiler.interim
13:31:39  Compiling 299 files for BUILD_jdk.javadoc.interim
13:32:20  
13:32:20  ERROR: Build failed for targets 'product-images legacy-jre-image test-image static-libs-image' in configuration 'linux-riscv64-normal-server-release' (exit code 2) 
13:32:20  
13:32:20  === Output from failing command(s) repeated here ===
13:32:20  * For target hotspot_variant-server_support_adlc_adlc_run:
13:32:20  /home/jenkins/workspace/build-scripts/jobs/evaluation/jobs/jdk11u/jdk11u-evaluation-linux-riscv64-temurin/workspace/build/src/build/linux-riscv64-normal-server-release/hotspot/variant-server/support/adlc/all-ad-src.ad(0) Semantic Error: :File read error, no input read
13:32:20  
13:32:20  
13:32:20  * All command lines available in /home/jenkins/workspace/build-scripts/jobs/evaluation/jobs/jdk11u/jdk11u-evaluation-linux-riscv64-temurin/workspace/build/src/build/linux-riscv64-normal-server-release/make-support/failure-logs.
13:32:20  === End of repeated output ===

@Haroon-Khel
Copy link
Contributor

The previous job, https://ci.adoptium.net/job/build-scripts/job/jobs/job/evaluation/job/jobs/job/jdk11u/job/jdk11u-evaluation-linux-riscv64-temurin/38/console which ran on dockerhost-azure-ubuntu2204-x64-1, failed in the same way

@Haroon-Khel
Copy link
Contributor

Haroon-Khel commented Aug 13, 2024

I think the error refers to this line in the source code https://github.com/openjdk/jdk11u/blob/3acdebea8539c12a7a6c6503976e8f74859d2264/make/hotspot/gensrc/GensrcAdlc.gmk#L182

  # Run the adlc tool on the single concatenated ad source file, and store the
  # output in support/adlc for further processing.
  ADLC_RUN_MARKER := $(ADLC_SUPPORT_DIR)/_adlc_run.marker

  $(ADLC_RUN_MARKER): $(BUILD_ADLC) $(SINGLE_AD_SRCFILE)
	$(call LogInfo, Generating adlc files)
	$(call MakeDir, $(@D))
	$(call ExecuteWithLog, $(ADLC_SUPPORT_DIR)/adlc_run, \
	    $(FIXPATH) $(ADLC_TOOL) $(ADLCFLAGS) $(SINGLE_AD_SRCFILE) \
	        -c$(ADLC_SUPPORT_DIR)/ad_$(HOTSPOT_TARGET_CPU_ARCH).cpp \

@sxa
Copy link
Member Author

sxa commented Aug 14, 2024

Given that https://ci.adoptium.net/job/build-scripts/job/jobs/job/evaluation/job/jobs/job/jdk11u/job/jdk11u-evaluation-linux-riscv64-temurin/40/console from the HEAD of the repository I wonder if the jdk-11.0.25+2_adopt tags are not being generated in a useful way as part of the mirroring process. I think this can be split out into a separate issue.

@sxa
Copy link
Member Author

sxa commented Sep 5, 2024

@Haroon-Khel Can this be closed now that we have an x64 Ubuntu24.04 dockerhost machine available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants