Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all Mac & Windows jdk.jpackage jmod executables are correctly signed #831

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

andrew-m-leonard
Copy link
Contributor

Ensure all the jdk.package JMOD executable resources are Signed
I think the stashing created a 0 length jpackagelauncher file, which then got .exe added and resulting empty file.

This PR ensures the whole jdk.jpackage resources folder is stashed for passing to the EF signing service.

@andrew-m-leonard andrew-m-leonard marked this pull request as draft October 26, 2023 10:58
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@andrew-m-leonard
Copy link
Contributor Author

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@andrew-m-leonard andrew-m-leonard self-assigned this Oct 26, 2023
@andrew-m-leonard
Copy link
Contributor Author

andrew-m-leonard commented Oct 26, 2023

Test build JDK looks good, JMOD jdk.jpackage resource exe/dll's are signed correctly

@andrew-m-leonard andrew-m-leonard marked this pull request as ready for review October 26, 2023 13:16
@andrew-m-leonard andrew-m-leonard changed the title Ensure all Mac & Windows jdk.jpackage jmod executeables are correctly signed Ensure all Mac & Windows jdk.jpackage jmod executables are correctly signed Oct 26, 2023
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm not an expert in this area the fix seems to have the desired effect, so approving :-)

…signed

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@gdams
Copy link
Member

gdams commented Oct 26, 2023

/merge

@github-actions
Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@sxa
Copy link
Member

sxa commented Oct 26, 2023

/approve

1 similar comment
@andrew-m-leonard
Copy link
Contributor Author

/approve

@github-actions github-actions bot dismissed their stale review October 26, 2023 13:22

Thank you @sxa and @andrew-m-leonard for your approvals, this pull request is now approved to merge during release.

@andrew-m-leonard andrew-m-leonard merged commit e882d5a into adoptium:master Oct 26, 2023
7 checks passed
andrew-m-leonard added a commit to andrew-m-leonard/ci-jenkins-pipelines that referenced this pull request Oct 26, 2023
…signed (adoptium#831)

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
andrew-m-leonard added a commit that referenced this pull request Oct 26, 2023
…signed (#831) (#832)

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
…signed (adoptium#831)

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants