Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke tests failures didn't block the run-aqa tests as expected. #121

Closed
sophia-guo opened this issue Apr 9, 2021 · 8 comments · Fixed by #681
Closed

Smoke tests failures didn't block the run-aqa tests as expected. #121

sophia-guo opened this issue Apr 9, 2021 · 8 comments · Fixed by #681
Assignees
Labels
bug generation Issues that provide enhancements or fixes to the job generators hotspot linux openj9 testing windows x64 Issues that affect or relate to the x64/x32 LINUX OS

Comments

@sophia-guo
Copy link
Contributor

sophia-guo commented Apr 9, 2021

We'd like smoke tests failures would block the run-aqa tests.

Now if smoke tests job generation failed the run-aqa tests are blocked.
https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk16u/job/jdk16u-windows-x64-openj9/16/console

However if smoke tests job generate correctly but job itself failed, run-aqa test was not blocked as expected.
https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk16u/job/jdk16u-linux-x64-hotspot/15/console

Probably need to update https://github.com/adoptium/ci-jenkins-pipelines/blob/master/pipelines/build/common/openjdk_build_pipeline.groovy#L292

@sophia-guo
Copy link
Contributor Author

@AdamBrousseau
Copy link
Contributor

Just wanted to confirm whether or not these smoke tests will be a blocker in time for the release next week? I know we've failed them internally since they were added but I haven't had a chance to investigate.

@sophia-guo
Copy link
Contributor Author

All smoke tests are limited to impl openj9 or vendors AdoptOpenJDK. There is no smoke tests for dragonwell ( impl=hotspot, vendor= alibaba) test jobs failed due to no test running TOTAL: 0 EXECUTED: 0 PASSED: 0 FAILED: 0 DISABLED: 0 SKIPPED: 0.

@smlambert should we just disable smoketest for dragonwell?

@smlambert
Copy link
Contributor

smlambert commented Apr 12, 2021

@sophia-guo - we can either:

Also, for the https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-aix-ppc64-hotspot_SmokeTests/1/console failure, JdkPlatform.javaL65 needs to be updated to either add or replace the arch string to match on, as os.arch must be returning ppc64 instead of ppc64le

13:58:01  Caused by: java.lang.AssertionError: Unrecognized architecture: ppc64
13:58:01  	at net.adoptopenjdk.test.JdkPlatform.detectArchitecture(JdkPlatform.java:90)
13:58:01  	at net.adoptopenjdk.test.JdkPlatform.<init>(JdkPlatform.java:27)
13:58:01  	at net.adoptopenjdk.test.BundledFreetypeTest.<init>(BundledFreetypeTest.java:42)

@sophia-guo
Copy link
Contributor Author

Move specific smoke test case failure to separate issue #127 as there are different failures. Fix would be in openjdk-build repos.

@zdtsw
Copy link
Contributor

zdtsw commented Sep 15, 2022

as part of issue #234

@github-actions github-actions bot added generation Issues that provide enhancements or fixes to the job generators hotspot linux openj9 windows x64 Issues that affect or relate to the x64/x32 LINUX OS labels Sep 15, 2022
@zdtsw
Copy link
Contributor

zdtsw commented Jan 30, 2023

e.g in the release smoketest job:
-https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/release/job/jobs/job/jdk19u/job/jdk19u-release-aix-ppc64-temurin_SmokeTests/1/console -- unstable
-https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/release/job/jobs/job/jdk8u/job/jdk8u-release-alpine-linux-x64-temurin_SmokeTests/2/console -- failed
they were not indicated in the upstream pipeline result. Mostly it is false alarm to release but could also be hidden problems.
for the non-temurin variant, we can move them to evaluation, but for the temurin'sgood to know what causes such

vsebe pushed a commit to vsebe/ci-jenkins-pipelines that referenced this issue Feb 14, 2023
…ntainer

Revert disable ccache and Rollback alinux container to last known good sha
@smlambert
Copy link
Contributor

has this now been completed and can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug generation Issues that provide enhancements or fixes to the job generators hotspot linux openj9 testing windows x64 Issues that affect or relate to the x64/x32 LINUX OS
Projects
No open projects
Status: Done
5 participants