Temporarily exclude security enabled JLM tests on Windows #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renfeiw
reviewed
Nov 27, 2018
systemtest/playlist.xml
Outdated
| @@ -1451,7 +1467,7 @@ | |||
| <impls> | |||
| <impl>openj9</impl> | |||
| </impls> | |||
| <platformRequirements>os.linux,^arch.ppc</platformRequirements> | |||
| <platformRequirements>os.linux,^arch.ppc,^os.win</platformRequirements> | |||
There was a problem hiding this comment.
you don't need to exclude this test, as it's linux only
There was a problem hiding this comment.
Rght! Thanks for spotting. There were few more of these. Updated them all.
Signed-off-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com>
Mesbah-Alam
force-pushed
the
excludeJlmAuthTestsOnWin
branch
from
7bae2a7
to
1feb438
Compare
renfeiw
approved these changes
Nov 27, 2018
systemtest/playlist.xml
Outdated
| @@ -1619,7 +1641,7 @@ | |||
| <impls> | |||
| <impl>openj9</impl> | |||
| </impls> | |||
| <platformRequirements>os.linux,^arch.ppc</platformRequirements> | |||
| <platformRequirements>os.linux,^arch.ppc,^os.win</platformRequirements> | |||
There was a problem hiding this comment.
you don't need to exclude this test, as it's linux only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily exclude security enabled JLM tests on Windows due to adoptium/aqa-systemtest#198
Signed-off-by: Mesbah Alam Mesbah_Alam@ca.ibm.com