Skip to content

Conversation

judovana
Copy link
Contributor

@judovana judovana commented Apr 1, 2025

depends on adoptium/TKG#688
Is using once declared macro

TKG_REPO="https://github.com/adoptium/TKG.git"
TKG_BRANCH="master"
TKG_REPO="https://github.com/judovana/TKG.git"
TKG_BRANCH="setupAbleJtreg"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is of course temporary

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unclear to me what the purpose of this PR is. We should not reference any personal repo in the main repo. If this is for personal testing, please use Grinder instead.

@judovana
Copy link
Contributor Author

judovana commented Apr 2, 2025

It is unclear to me what the purpose of this PR is. We should not reference any personal repo in the main repo. If this is for personal testing, please use Grinder instead.

Of course. "This is of course temporary". But the PR do not have sense without adoptium/TKG#688 so I hardcoded it. This one can go in only after adoptium/TKG#688 and once adoptium/TKG#688 goes in, I will remove the hardcoded repo/branch. The change to see is the second file

@smlambert
Copy link
Contributor

You do not need to create a PR in aqa-tests to test changes that are done in TKG, there is a field in our test pipeline jobs (including Grinder) that can be set TKG_OWNER_BRANCH=judovana:setupAbleJtreg.

Additionally, if you are to create an aqa-tests branch, you do not need to create a draft or a pr to refer to it, you can push it and decline to create a PR, and still be able to refer to it.

On the topic of adoptium/TKG#688, there does not seem to be any issue that describes why that is needed. I presume its a feature request to support the use of custom jtreg.jar (which no one uses except RH QE as far as I am aware). In our previous discussions on the topic, we do not want to use random untagged/unchecked test dependencies, but I can add a note to the TKG PR to repeat that previously discussed topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants