-
-
Notifications
You must be signed in to change notification settings - Fork 332
Using jtreg.jar as declared in TKG #6125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
TKG_REPO="https://github.com/adoptium/TKG.git" | ||
TKG_BRANCH="master" | ||
TKG_REPO="https://github.com/judovana/TKG.git" | ||
TKG_BRANCH="setupAbleJtreg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is of course temporary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is unclear to me what the purpose of this PR is. We should not reference any personal repo in the main repo. If this is for personal testing, please use Grinder instead.
Of course. "This is of course temporary". But the PR do not have sense without adoptium/TKG#688 so I hardcoded it. This one can go in only after adoptium/TKG#688 and once adoptium/TKG#688 goes in, I will remove the hardcoded repo/branch. The change to see is the second file |
You do not need to create a PR in aqa-tests to test changes that are done in TKG, there is a field in our test pipeline jobs (including Grinder) that can be set TKG_OWNER_BRANCH=judovana:setupAbleJtreg. Additionally, if you are to create an aqa-tests branch, you do not need to create a draft or a pr to refer to it, you can push it and decline to create a PR, and still be able to refer to it. On the topic of adoptium/TKG#688, there does not seem to be any issue that describes why that is needed. I presume its a feature request to support the use of custom jtreg.jar (which no one uses except RH QE as far as I am aware). In our previous discussions on the topic, we do not want to use random untagged/unchecked test dependencies, but I can add a note to the TKG PR to repeat that previously discussed topic. |
depends on adoptium/TKG#688
Is using once declared macro