Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark node offline if cannot delete workspace #5636

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Sep 19, 2024

related: #5358 and infrastructure/issues/9874

related: adoptium#5358 and infrastructure/issues/9874
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
@llxia
Copy link
Contributor Author

llxia commented Sep 19, 2024

Grinder - We do not have a machine for testing cannot delete workspace case. The Grinder is to ensure the PR does not break the regular case.

@JasonFengJ9
Copy link
Contributor

The change looks fine, just wondering if there is a hint about the error for the infra when the machine is offline?

@llxia
Copy link
Contributor Author

llxia commented Sep 19, 2024

A message will be posted on the #rt-jenkins channel. For example link

The same message will be added on the Jenkins machine page.

@JasonFengJ9 JasonFengJ9 merged commit 277f44f into adoptium:master Sep 19, 2024
2 checks passed
llxia added a commit to llxia/aqa-tests that referenced this pull request Sep 23, 2024
related: adoptium#5358 and infrastructure/issues/9874

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
LongyuZhang pushed a commit that referenced this pull request Sep 23, 2024
related: #5358 and infrastructure/issues/9874

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants