Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable serviceability_jvmti tests for 19+ #4035

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Oct 13, 2022

Related with #4006

Signed-off-by: Sophia Guo sophia.gwf@gmail.com

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
@sophia-guo
Copy link
Contributor Author

sophia-guo commented Oct 13, 2022

This test case hotspot_serviceability_jvmti can be combined with test case serviceability_jvmti_j9, which is specifying nativepath by -nativepath:"$(TESTIMAGE_PATH)/hotspot/jtreg/native" and I don't think it works. However even if updated as $(JVM_NATIVE_OPTIONS) it probably won't work too for openj9, as openj9 may not build corresponding test libs.

As mentioned in #3970 (comment) there are 94 tests failed, which is same number of test failure with hotspot if nativepath is not set correctly or testimage is missing https://ci.adoptopenjdk.net/job/Grinder/5731/testReport/

@sophia-guo
Copy link
Contributor Author

As we may gradually enable other Loom related tests #4006 (comment) in one test case, which might not work with openj9 or openj9 might not be interested in. I will leave it as is for now, which can be combined easily later if required.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I had assumed we were running all tests with --enable-preview which would cause failures in 19 but on the basis of the grinders that's not the case, so I approvel

@karianna karianna merged commit 81d0f11 into adoptium:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants