-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Dynamic agent #2397
Enable Dynamic agent #2397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with the update to remove the windows fyre option.
@smlambert updated. We will also need to update azure VM test agent's label be |
re: #2397 (comment) azuretestagent is now updated with |
I will also note that this PR is using centos6_build_image as the test container. @sxa has been compiling a list of tests that do not run well in containers in #2138, and making updates to static container nodes he has created. I think it may be valuable to have a test container with any/all updates that Stewart has been making in his investigation and use it in place of the centos6_build_image. |
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
689d3bf
to
984b10e
Compare
buildenv/jenkins/testJobTemplate
Outdated
@@ -246,6 +245,7 @@ ARCH_OS_LIST.each { ARCH_OS -> | |||
stringParam('UPSTREAM_TEST_JOB_NAME', "", "Auto-populated. Upstream test job name. It will be used together with PARALLEL=Dynamic") | |||
stringParam('UPSTREAM_TEST_JOB_NUMBER', "", "Auto-populated. Upstream test job number. It will be used together with PARALLEL=Dynamic") | |||
booleanParam('LIGHT_WEIGHT_CHECKOUT', LIGHT_WEIGHT_CHECKOUT.toBoolean(), "Optional. Default is false for Grinders") | |||
stringParam('CLOUD_PROVIDER', CLOUD_PROVIDER, "available cloud provider") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick, capitalize Available to match the other param descriptors that are capitalized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are updating this line, could you also provide examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
} | ||
} else { | ||
boolean isNodeIdle = false | ||
node('master') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eclipse OpenJ9 Jenkins does not have any executors on master so this won't work there.
Signed-off-by: Sophia Guo sophia.gwf@gmail.com