Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Dynamic agent #2397

Merged
merged 4 commits into from
Mar 25, 2021
Merged

Enable Dynamic agent #2397

merged 4 commits into from
Mar 25, 2021

Conversation

sophia-guo
Copy link
Contributor

Signed-off-by: Sophia Guo sophia.gwf@gmail.com

@karianna karianna added this to the March 2021 milestone Mar 23, 2021
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the update to remove the windows fyre option.

@sophia-guo
Copy link
Contributor Author

sophia-guo commented Mar 24, 2021

@smlambert updated. We will also need to update azure VM test agent's label be ci.role.test&&hw.arch.x86&&sw.os.linux&&ci.agent.dynamic.

@smlambert
Copy link
Contributor

re: #2397 (comment) azuretestagent is now updated with ci.role.test&&hw.arch.x86&&sw.os.linux&&ci.agent.dynamic label

@smlambert
Copy link
Contributor

I will also note that this PR is using centos6_build_image as the test container.

@sxa has been compiling a list of tests that do not run well in containers in #2138, and making updates to static container nodes he has created. I think it may be valuable to have a test container with any/all updates that Stewart has been making in his investigation and use it in place of the centos6_build_image.

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
@sophia-guo sophia-guo force-pushed the azureVM branch 2 times, most recently from 689d3bf to 984b10e Compare March 24, 2021 15:00
@@ -246,6 +245,7 @@ ARCH_OS_LIST.each { ARCH_OS ->
stringParam('UPSTREAM_TEST_JOB_NAME', "", "Auto-populated. Upstream test job name. It will be used together with PARALLEL=Dynamic")
stringParam('UPSTREAM_TEST_JOB_NUMBER', "", "Auto-populated. Upstream test job number. It will be used together with PARALLEL=Dynamic")
booleanParam('LIGHT_WEIGHT_CHECKOUT', LIGHT_WEIGHT_CHECKOUT.toBoolean(), "Optional. Default is false for Grinders")
stringParam('CLOUD_PROVIDER', CLOUD_PROVIDER, "available cloud provider")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick, capitalize Available to match the other param descriptors that are capitalized

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are updating this line, could you also provide examples?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 42b30ea into adoptium:master Mar 25, 2021
}
} else {
boolean isNodeIdle = false
node('master') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eclipse OpenJ9 Jenkins does not have any executors on master so this won't work there.

llxia added a commit that referenced this pull request Mar 25, 2021
sophia-guo pushed a commit that referenced this pull request Mar 25, 2021
@sophia-guo sophia-guo mentioned this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants